Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emit debug log on blockheight metric from websockets #89

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: emit debug log on blockheight metric from websockets #89

merged 1 commit into from
Dec 2, 2022

Conversation

brianluong
Copy link
Member

@brianluong brianluong commented Nov 22, 2022 •
edited
Loading

Description

Actually we are emitting metrics for this. Added a debug log too.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

dianwen
dianwen approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@dianwen dianwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we weren't seeing metrics for bor yesterday when it was staying close to head. any idea why if we're emitting metrics?

@brianluong
Copy link
Member Author

I remember we weren't seeing metrics for bor yesterday when it was staying close to head. any idea why if we're emitting metrics?

Oh shoot, didn't see this comment until now. TBH I'm not sure. This was 2 weeks ago so the context isn't fresh in my head anymore 😢

@brianluong brianluong merged commit 41b19fe into main Dec 2, 2022
@brianluong brianluong deleted the debugLogWebsocket branch December 2, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianwen dianwen dianwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianluong @dianwen